| Package | Affected versions | Patched versions |
|---|---|---|
| nicegui | ≥ 2.22.0, < 3.5.0 | 3.5.0 |
| nicegui | ≥ 2.22.0, < 3.5.0 | 3.5.0 |
An unsafe implementation in the pushstate event listener used by ui.sub_pages allows an attacker to manipulate the fragment identifier of the URL, which they can do despite being cross-site, using an iframe.
The problem is traced as follows:
pushstate, handleStateEvent is executed.handleStateEvent emits sub_pages_open event.SubPagesRouter (used by ui.sub_pages), lisnening on sub_pages_open, _handle_open runs._handle_open finds any SubPages and runs _show() on themself._handle_scrolling(match, behavior='smooth') directly_handle_scrolling runs _scroll_to_fragment as there is a fragment, which runs vulnerable JS if the fragment (attacker-controlled) escapes out of the quotes.Just visiting this page (no click required), consistently triggers XSS in https://nicegui.io domain.
<html>
<body>
<iframe id="myiframe" src="https://nicegui.io" width="100%" height="600px" onload="triggerXSS()"></iframe>
<script>
function triggerXSS() {
if (!myiframe.src.includes("#")) {
myiframe.src = "https://nicegui.io#x');alert(document.domain)//";
}
}
</script>
</body>
</html>
Any page which uses ui.sub_pages and does not actively prevent itself from being put in an iframe is affected.
The impact is high since by-default NiceGUI pages are iframe-embeddable with no native opt-out functionalities except by manipulating the underlying app via FastAPI methods, and that ui.sub_pages is actively promoted as the new modern way to create Single-Page Applications (SPA).
ui.sub_pages@app.middleware('http')
async def iframe_blocking_middleware(request, call_next):
response = await call_next(request)
response.headers['X-Frame-Options'] = 'DENY'
return response
AI is used safely to judge the CVSS scoring (input is censored).
Please find the results in https://poe.com/s/3FXuwp7TAYxqLomARXma
The scoring done by AI was quite biased. Upon further review it is less dramatic.
Running one of these products? Scan your site to see whether it exposes a vulnerable version.
Scan my site free