serverless MCP Server vulnerable to Command Injection in list-projects tool

Summary

A command injection vulnerability exists in the Serverless Framework's built-in MCP server package (@serverless/mcp). This vulnerability only affects users of the experimental MCP server feature (serverless mcp), which represents less than 0.1% of Serverless Framework users. The core Serverless Framework CLI and deployment functionality are not affected.

The vulnerability is caused by the unsanitized use of input parameters within a call to child_process.exec, enabling an attacker to inject arbitrary system commands. Successful exploitation can lead to remote code execution under the server process's privileges.

The server constructs and executes shell commands using unvalidated user input directly within command-line strings. This introduces the possibility of shell metacharacter injection (|, >, &&, etc.).

Details

The MCP Server exposes several tools, including the list-project. The values of the parameter workspaceRoots (controlled by the user) is used to build a shell command without proper sanitization, leading to a command injection.

Vulnerable code

// https://github.com/serverless/serverless/blob/6213453da7df375aaf12fb3522ab8870488fc59a/packages/mcp/src/tools/list-projects.js#L68
export async function listProjects(params) {
  // Mark that list-projects has been called
  setListProjectsCalled()

  const { workspaceRoots, userConfirmed } = params

  ...
    // Process each workspace root
    for (const workspaceRoot of workspaceRoots) {
      const projectsInfo = await getServerlessProjectsInfo(workspaceRoot) //<----
    }
    

// https://github.com/serverless/serverless/blob/6213453da7df375aaf12fb3522ab8870488fc59a/packages/mcp/src/lib/project-finder.js#L170-L177
export async function getServerlessProjectsInfo(workspaceDir) {
  // Find all serverless projects in the workspace by type
  const [serverlessFrameworkProjects, cloudFormationProjects, awsSamProjects] =
    await Promise.all([
      findServerlessFrameworkProjects(workspaceDir), //<----
      findCloudFormationProjects(workspaceDir),
      findAwsSamProjects(workspaceDir),
    ])
    
    
// https://github.com/serverless/serverless/blob/6213453da7df375aaf12fb3522ab8870488fc59a/packages/mcp/src/lib/project-finder.js#L24
export async function findServerlessFrameworkProjects(workspaceDir) {
	...
	const { stdout } = await execAsync(
	      `find "${rootDir}" -name "serverless.yml" -not -path "*/node_modules/*" -not -path "*/\.git/*"`, //<----
	      { maxBuffer: 10 * 1024 * 1024 }, // Increase buffer size for large workspaces
	)

// https://github.com/serverless/serverless/blob/6213453da7df375aaf12fb3522ab8870488fc59a/packages/mcp/src/lib/project-finder.js#L58-L66
async function findYamlFiles(workspaceDir) {
	...
	const { stdout: yamlStdout } = await execAsync(
	    `find "${rootDir}" -name "*.yaml" -not -path "*/node_modules/*" -not -path "*/\.git/*"`,
	    { maxBuffer: 5 * 1024 * 1024 }, // Increase buffer size for large workspaces
	)
	
	const { stdout: ymlStdout } = await execAsync(
		`find "${rootDir}" -name "*.yml" -not -path "*/node_modules/*" -not -path "*/\.git/*"`,
		{ maxBuffer: 5 * 1024 * 1024 }, // Increase buffer size for large workspaces
	  )